LE GARREC Vincent

icon indicating a website link https://wiki.le-garrec.fr icon indicating an email [email protected]

icon location Tours, France icon location I always work on lots of things, so I often don't have time to finish projects. Feel free to ask for updates on any project that you find interesting!

Results 65 comments of LE GARREC Vincent

Improve portability for external pugixml

This looks good. You do: ``` if (OPENXLSX_ENABLE_NOWIDE) if (OPENXLSX_ENABLE_LIBBOOST_NOWIDE) find_package(Boost 1.74 REQUIRED COMPONENTS nowide) # on Linux at least, this requires libboost-nowide-dev to be installed else() add_library(NoWide INTERFACE IMPORTED)...

Improve portability for external pugixml

If `nowide` may not be header-only, you will probably need to use `PUBLIC` in `target_link_libraries` to allow static linkage.

Improve portability for external pugixml

> > If `nowide` may not be header-only, you will probably need to use `PUBLIC` in `target_link_libraries` to allow static linkage. > > Oh yeah that was something I did...

Improve portability for external pugixml

* libzip cmake files > Hi again! I commited [17aee0e](https://github.com/troldal/OpenXLSX/commit/17aee0e496fb19fe30906693086d69ee7c8690ee) which implements `find_package` for `LibZip` and `PugiXML`. However, I just wasted 3+ hours of my life trying to find out...

Improve portability for external pugixml

> > Read /usr/lib/x86_64-linux-gnu/cmake/libzip/libzip-config.cmake > > There is an include libzip-targets.cmake > > You can see that zipcmp / zipmerge / ziptool is hardcoded. So they are mandatory. > >...