Daniel Porteous (dport)

@rajkaramchedu, for when you look at this next week, a quick guide. With the new API, the spec is generated from the code, vs them being separately written by hand....

The situation has improved a bit given some updates to the `aptos-openapi` crate (5200f1da52725d3fcd9d2581405c1bd9e1a0c71a), we can now represent types as objects, not just strings, attach helpful metadata, and use refs...

I feel like it makes more sense to configure this via runtime arguments (the config / CLI). Do you expressly need to modify failpoints during a single process lifetime?

With the API changes I'm making we can conditionally include certain groups of endpoints in the API. This should definitely be an opt in feature, we don't want it to...

We don't really configure much via features today for the API, all configuration is done via a config file. You can imagine that having different permutations of features for our...

Yeah my stance is: - Configuring via the API is okay given you need to be able to change these failpoints within a single process lifetime. - The endpoints should...

Okay fair enough, we can do that.

That's not quite what the latest discussion has been about, we've been discussing whether to enable the failpoints API at all via either a feature or a config flag. I...

Thanks for this, I'll take a look soon!

Currently this isn't feasible with Dolphin as it is, since you can't alter reviews once you've added them. You also can't not add them as you perform them, otherwise Dolphin...