Paul Banks
Paul Banks
Fixes #63 Comments welcome. I added registration to existing sub-package sinks. Happy to leave that out if there is a good reason to not auto-register those. I added some basic...
In my case, I'd like to use the provided sub-package Dogstatsd sink but without loosing the abstraction this library provides. While I could write my own config/setup method that parses...
Hi, got this running fine on OS X via homebrew duplicity install. I'm now trying to get it running on my [WebFaction](http://webfaction.com) account. I have managed to compile the deps...
The current draft spec does't anywhere define what values `proxy_action_t` might take. The C++ and Rust SDKs also seem to diverge on this, the Rust SDK only provides `Action::Continue` and...
This is partly a suggestion about clarifying security model docs and partly a suggestion to improve the overall security of this integration if I'm understanding the current model correctly. The...
https://github.com/haproxytech/haproxy-consul-connect/blob/master/consul/watcher.go I see a couple of issues in the watcher: - `removeUpstream` is setting a done bool under lock but the startUpstream loop reads that bool while not holding the...
https://github.com/haproxytech/haproxy-consul-connect/blob/55bff42d10d53e3d5942a84ec6d704802d0b4317/main.go#L57-L59 This is a naming convention only and there is nothing in Consul stopping users from naming proxies differently if they don't use the sidecar_service helper. The canonical way to...
Note if this is changed it might make #7 invalid. https://github.com/haproxytech/haproxy-consul-connect/blob/55bff42d10d53e3d5942a84ec6d704802d0b4317/main.go#L61-L68 Having skipped sidecars (assuming that works, see #7), this code attempts to find the first tag match on an...
In https://github.com/haproxytech/haproxy-consul-connect/blob/556c75e4dede0754103b0b39b4d3f523be90cc13/consul/config.go I see some struct duplication from the ones in our `api` package. Is there a good reason to need that vs just embedding our api package structs (say...
We very purposefully don't have a mode in Connect where you can choose to not enforce intentions. I'd strongly recommend not including one in this integration either. It's understandable if...