Wolfgang Bangerth
Wolfgang Bangerth
Is this PR superseded by #3771? If so, we should probably close it.
@MFraters What's the status of this PR?
That's ok, but for the record, it is typically easier to review two smaller patches than one large one :-)
Separately: * You've got a file `data/geometry-model/initial-topography-model/ascii-data/test/.DS_Store`. Please remove that from the patch. * Did you really mean to add a text file with 250,000 lines? What does it represent?
@elodie-kendall What help do you need to get this pushed over the finish line?
Yes, examples are always good, as they make sure that what works today also works tomorrow! As for the merge conflict: You added an entry to the `.bib` file, but...
@elodie-kendall What should we do with this pull request?
@gassmoeller says "Don't merge yet"!
@pmbremner Take a look at the pull requests linked to in the original post and compare with what's currently in the code base. If the issues mentioned (code duplication) persist...
Will review after dinner. If you want to make sure that the indentation is correct before I get to it, that'll be fine too.