aspect
aspect copied to clipboard
geodynamics
[WIP] Postprocessor for "plateness"
This PR is inspired by the parameter in Lourenco et al., 2020 which computes how plate like the lid in spherical models is. This PR is in it's early stages but the bulk part is there and we can hopefully fix the few remaining issues.
Before your first pull request:
- [X ] I have read the guidelines in our CONTRIBUTING.md document.
For all pull requests:
- [ X] I have followed the instructions for indenting my code.
For new features/models or changes of existing features:
- [X ] I have tested my new feature locally to ensure it is correct.
- [ ] I have created a testcase for the new feature/benchmark in the tests/ directory.
- [ X] I have added a changelog entry in the doc/modules/changes directory that will inform other users of my change.
@tjhei: I asked @elodie-kendall to open this PR in an incomplete state to be able to leave comments directly on the code. I will add some more comments later.
Thanks a lot for your comments, @tjhei, @gassmoeller. I've addressed them all, I'm just stuck with these last two issues:
Elodie, try reading the error messages. The first one says paraphrased "You are trying to add a double and a Tensor. I don't know know how to do that." That of course doesn't make any sense. Agreed?
@elodie-kendall What help do you need to get this pushed over the finish line?
Thanks for your reminder @bangerth. I've addressed your comments and it now compiles. I was thinking to add an example with the burnman_test.prm, that's ok for you? If so I'd remove the part which gets and uses the minimum strain rate as that is not an input for the ascii ref prof. BTW, I'm not sure why it says there's a conflict in .bib because this compiled fine locally..
Yes, examples are always good, as they make sure that what works today also works tomorrow!
As for the merge conflict: You added an entry to the .bib file, but someone else did the same in a patch that was merged after you proposed yours. And because both add an entry to the end of the file, git says "these patches conflict". You'll have to resolve this "merge conflict" before this can be merged.