Andrzej Warzyński comments

Results 93 comments of


                                            Andrzej Warzyński

Missing vectorization for gather ops

Hello 👋🏻 I am new to IREE and to this community, so apologies if I'm digressing too much. Please let me know if a new thread would be better. >...

[IDEA] const-qualify tool

> Probably all those functional languages rubbing off on me! haha, I knew! > On the surface I'm not thinking this would be particularly difficult… at least for the majority...

Fix building against LLVM/Clang configured with BUILD_SHARED_LIBS=ON

Looking at the [definition](https://github.com/llvm/llvm-project/blob/main/clang/cmake/modules/AddClang.cmake#L149-L153) of `add_clang_executable`, it feels that `add_llvm_executable` should be sufficient for us. Similarly, `clang_target_link_libraries` could be replaced with `target_link_libraries`. So, `include(AddLLVM)` could be replaced with `include(AddClang)`, which...

[IDEA] Convert types to correct ones: `for(int i=0; i<vec.size(); i++)` => `for(size_t i=0; i<vec.size(); i++)`

Hey, This would be incredibly useful, yes! Which makes me wonder - has there been any prior art? Have you tried [UndefinedBehaviorSanitizer](https://clang.llvm.org/docs/UndefinedBehaviorSanitizer.html)? With this sort of tools, you want to...

[IDEA] Convert types to correct ones: `for(int i=0; i<vec.size(); i++)` => `for(size_t i=0; i<vec.size(); i++)`

So you probably want to start with something simple like this: ```cpp void foo() { unsigned K = 10; for (int k = 0; k < K; k++) ; }...

[IDEA] Convert types to correct ones: `for(int i=0; i<vec.size(); i++)` => `for(size_t i=0; i<vec.size(); i++)`

There's [https://github.com/banach-space/clang-tutor/tree/main/HelloWorld](HelloWorld) as a minimal example. But otherwise, yeah, takes a bit of time to set everything up.

JIT related?

Hi, thank you for visiting and for your kind words! A tutorial on JIT is a great suggestion, thank you! I'll add it to my _not so short_ list of...

Example for instrumenting source code

Hi @ArchanaaSK, Thank you for visiting and for your question! > Do you have any example plugins for adding functions to source code? No, I've not tried implementing anything like...

Questions about rationale of ASTMatcher and RecursiveASTVisitor?

Hello 👋🏻 ! > Thanks for you excellent tutorial Thank you for your kind words! :) > why ASTMatcher would work? you use API LoopVar->isUsed(true) in [line 64 of UnusedForLoopVar.cpp](https://github.com/banach-space/clang-tutor/blob/main/lib/UnusedForLoopVar.cpp#L64)...

What's the difference between TraverseForStmt and VisitForStmt?

Hello @zhou-shulin , thank you for stopping by :) Apologies for the delay, I was away for a couple of weeks. The difference between these methods is documented [here](https://github.com/llvm/llvm-project/blob/40fd2d93c0ac694dce49e1d52f585752d011d884/clang/include/clang/AST/RecursiveASTVisitor.h#L99-L163). It's...