Baptiste Mouginot
Baptiste Mouginot
@pshriwise I have addressed your last comments, let me know if you have more :)
> There's a lot of nice work here. My remaining concern is the structure of the `material_overrides` attribute. I think this data structure should only accept Cell IDs as keys....
I let you decide if making openmc.lib mandatory is ok or not.
> > I let you decide if making openmc.lib mandatory is ok or not. > > I think it's reliance on `openmc.lib` is okay. Our plotter capabilities rely heavily on...
Also I had to keep a prefix for the xml attribute as it seems that an attribute cannot be a `int`. so I kept a "Cell_" prefix which I remove...
In the data structure yes: if material A is assigned initially in Cell ids [X,Y,Z] the data structure will look like: `{"Cell_X":[B], "Cell_Y":[B], "Cell_Z":[B]}`, _The "Cell\_" prefix is automatically taken...
@pshriwise I reshaped the xml layout. it now looks like: ``` ``` I kept the ";" separator between material values, as material name could be passed, so I thought semicolon...
> didn't catch that we might write material names to XML in our conversation above, sorry. Any reason not to limit the values of the overrides data structure to Material...
@pshriwise ready of an other round :)
I just discovered working on #3264 (while it might be obvious for more experienced OpenMC Master) that the newly merged DAGMC override material feature (see #3056) occurs after vacuum and...