Baptiste Mouginot
Baptiste Mouginot
@pshriwise I think I have addressed all your comments. (factorisation of the different Universe methods between `UniverseBase`, `Universe` and `DAGMCUniverse`) and created a specific `dagmc.py` that contains `DAGMCUniverse` and `DAGMCCell`...
@pshriwise following up on the CI issue I mentioned Friday: as you can see in the commit history: [3197ee4](https://github.com/openmc-dev/openmc/pull/3056/commits/3197ee4d3616d3714018aadebece9e6b753d79a9) passed, but [3a7c19c](https://github.com/openmc-dev/openmc/pull/3056/commits/3a7c19c23846d50beccfcbebf2f284efceb8e05e) didn't. the only difference is: openmc/model/model.py ```diff @@...
@pshriwise, I think I have addressed all your comments. the only remaining is the reference the materials per id in the override_material dict
@pshriwise I think I have addressed all your comments.
@pshriwise I think I addressed your last round of comments. As I moved the DAGMCUniverse from `openmc.universe` to `openmc.dagmc` and shuffled some methods from `Universe` to `UniverseBase` , in the...
@pshriwise here is an other illustration of the CI inconsistance: https://github.com/bam241/openmc/pull/1 I have a PR with this branch on my fork, the `[Python 3.10 (omp=y, mpi=y, dagmc=y, ncrystal=, libmesh=, event=...
@pshriwise I added an other test, to check more extensively what is done, I can probably factorise some code between the 2 tests, will do today or tomorrow. Not that...
I also, make an addition split method, to allow splitting based on an arbitrary `delim`, some material names (i.e. in the actual `dagmc.h5` used in the test) have space in...
@pshriwise this is ready for a other round of review :)
@pshriwise I think I addressed to all your questions or comments. I left 1 unresolved comment, so you can "ok" how I have addressed your question about the `uwuw` assignment.