balthazar comments

Results 87 comments of


                                            balthazar

Hidden cyclical dependency in base

I agree, this cause cycle requires in some environments which could potentially be error-prone

Not able to update timer value inside ajax success response block.

You could also use `ng-if` on your timer element to check for your `startTime` variable. This way, the directive will only be initialised when you have your date, and it...

error: The final argument to magicString.overwrite(...) should be an options object

Which still seem to be unresolved for now 🙁

Cannot read property minify of null

Arrrrgh totally my bad, can you install the `0.0.6` version?

Cannot read property minify of null

Hey pedronauck! Don't cry! :smile: Can you check the content of the package installed? The version in the module `package.json` is `0.0.6`? Checking the [unpkg](https://unpkg.com/[email protected]) returns me the correct `index.js`

Cannot read property minify of null

I think this is an issue with butternut itself rather than the module then, a similar issue has been reported in [#123](https://github.com/Rich-Harris/butternut/issues/123), as @estrattonbailey said, you need to remove the...

Cannot read property minify of null

Reopening for visibility, it's quite annoying that setting the production env does this, since butternut is intended to be run only with this one

Cannot read property minify of null

Bumped all deps in `0.1.0`, let me know.

wip: Improvements

Hey! Thanks for this! Regarding the multiples patches you propose: - I prefer keep using the es2015 preset rather than limiting people to node 4. - A single `index.js` inside...

wip: Improvements

Yep I agree, if you could make a separate PR containing the change of regex, that would be better for me. If you think giving the ability to the user...