Baldur Karlsson

DecompressBC6_Internal doesn't seem to handle signed BC6 data

2

The code in `DecompressBC6_Internal` seems to always assume unsigned data. When passed a block that contains signed data the half conversion fails. Note that `m_bc6signed` is local and not modified...

Compiling this shader with `glslc --target-env=vulkan1.2 test.spvasm -o test.spv`: ``` OpCapability Shader OpMemoryModel Logical GLSL450 OpEntryPoint Fragment %main "main" %gl_FragColor OpExecutionMode %main OriginUpperLeft OpSource GLSL 330 OpName %main "main" OpName...

[SPIR-V] debug info should emit DebugEntryPoint with compiler info

5

The SPIR-V debug information emitted via `NonSemantic.Shader.DebugInfo.100` doesn't currently emit `DebugEntryPoint` for the entry point being compiled. This is a useful piece of metadata as it includes the compiler identifier...

[SPIR-V] Debug info should use DebugBuildIdentifier and DebugStoragePath with -Fd flag

1

This is a request for the `NonSemantic.Shader.DebugInfo.100` SPIR-V debug info to use the `DebugBuildIdentifier` and `DebugStoragePath` opcodes to support split debuginfo files. For context how it works on the DXIL...

As in the title, size 0 to vkMapMemory is invalid according to the spec: > If size is not equal to VK_WHOLE_SIZE, size must be greater than 0 I assume...

Add tests for invalid pointers that must be ignored

1

There are a number of places in the API where struct pointers have to be explicitly ignored by drivers when they are unused. For example in `vkGraphicsPipelineCreateInfo`, `pDepthStencilState` is ignored...

Add tests for dynamic state with compute

1

I ran into a driver crash where doing (sketched): ``` vkBeginCommandBuffer(cmd, PRIMARY); vkCmdSetLineWidth(cmd, 1.0); vkCmdBindPipeline(cmd, VK_PIPELINE_BIND_POINT_COMPUTE, pipe); // empty main() in compute pipeline, no descriptors vkCmdDispatch(1, 1, 1); vkEndCommandBuffer(cmd); vkQueueSubmit(......

The same bug as in nvpro-samples/gl_vk_bk3dthreaded#4, `queueInfo.pQueuePriorities` isn't set in NVK.cpp, so it ends up being NULL which is invalid.

Around [here](https://github.com/nvpro-samples/gl_vk_bk3dthreaded/blob/master/NVK.cpp#L718-L719) in the code the queue info shoudl be setting queue priorities, these are mandatory according to the spec section 4.3.2: > pQueuePriorities must be a pointer to an...

Running tasks via WaitForTask(NULL)

2

I want to be able to say "wait up to N microseconds on the current thread for a task to be executable then run at most one task", and optionally...