Baldur Karlsson

Results 127 comments of Baldur Karlsson

Ah yeh, I'm on windows 7. Indeed on my windows 10 test machine it works fine, I should have thought to try that. If this isn't feasible to support then...

Also somewhat related, `CreateOptionsBC6` overwrites the source pointer because it's missing an indirection: https://github.com/GPUOpen-Tools/compressonator/blob/7104e6a977215b2b37acf0fce493dd11eac022bf/Compressonator/CMP_Core/shaders/BC6_Encode_kernel.cpp#L3802-L3808 The call to `SetDefaultBC6Options` needs to pass `*options` (and I think so does the first if).

AFAIK that can be quite dangerous since depending on compiler settings it will be optimised out entirely. If you're implementing it by hand I believe it's likely better to check...

I think the signature is primarily for debugging/human use, e.g. if a miscompilation is found then the compiler can be identified to see if a bugfix is present or not....

FYI I don't really recommend that anyone else use my code for modifying DXIL. I wrote it because I was forced to with no other realistic choice for some debugging...

I ran into this today as well. I think it goes back to [this change](http://repo.or.cz/git-gui.git?a=commit;h=577c7e8fc663bc0e31b10e8691f03c3361dedc51) upstream, which prevents the code from running through cygpath to convert unix paths to windows...

That's perfect, thanks. Indeed knowing that it only runs one task is the key. It would be nice to have a more flexible way of doing this with a timeout,...

Closing this due to lack of activity.

Yes if you want to resume work on it you can reopen the PR. I closed it because I'd asked questions/given review feedback and it hadn't been addressed or replied...

Ah OK. Yeh then open a new PR when you're ready to work on it again, not much in this one anyway.