Balázs Kéri

Maybe the problems only occur when the scope is explicitly written in source code (like at `X::A` and `Y::A` only `A` is checked). So the "written string" could be compared,...

There is a related pull request #629.

> I wonder if behavior of this check should be an extension to [optin.core.EnumCastOutOfRange](https://clang.llvm.org/docs/analyzer/checkers.html#optin-core-enumcastoutofrange). Sure, we don't have `static_cast` here but it's still considered as "cast out of range"? Maybe...

I have fixed the review issues.

The check can now warn for (default) initializations that are recursively inside a type structure (members of structs, elements of arrays). In these cases it can look difficult to find...

We should ensure that the code builds with `-DBUILD_SHARED_LIBS=ON` cmake option. I think this is why I can not build it. I get this error: ``` /usr/bin/ld: tools/clang/lib/AST/CMakeFiles/obj.clangAST.dir/ASTImporter.cpp.o: in function...

I think that `ASTImporter` must be moved into a new component (directory in "clang/lib") to fix this problem. `AST` is already dependency of `Sema` so `Sema` can not be added...

I checked the code and it looks difficult to split the `ASTImporter` to a separate component. The problem is that `ExternalASTSource` is used for AST related things and uses `ASTImporter`...

I have now a working patch for "splitting" `ASTImporter` from `AST`. If this change will be accepted it is possible to add the new visit functions. The "split" change may...

After change #141104 it is possible to compile and link the code without problems. There are some things to fix in this patch (with naming and formatting rules and code...