arya dradjica comments

Results 67 comments of


                                            arya dradjica

Rewrite the `fish` plugin from scratch

There seems to be some weird issue with test coverage. @snejus, any idea what's going on?

Rewrite the `fish` plugin from scratch

@snejus I tried `pull_request_target`, but it looks like that disabled CI checking for the PR entirely. Is there any good way to disable specifically the upload-coverage action for PRs?

Replace most `str.format()` uses with f-strings

> Thank you for the monster commit. Hopefully you had automation to aid you. I only looked at the first few chunks (about as far as my final comment) but...

Replace most `str.format()` uses with f-strings

@Serene-Arc, I think the primary remaining blocker is a thorough review of the SQL function change. I've fixed the URL formatting and the "title, article" implementation as well. Don't worry...

Fix the no_convert option of the convert plugin stopping conversion when there is only a partial match.

I'm looking at the documentation for `no_convert`: > Does not transcode items matching the query string provided (see [Queries](https://beets.readthedocs.io/en/stable/reference/query.html)). For example, to not convert AAC or WMA formats, you can...

Migrate tests from `unittest` to `pytest`

I'd like to take on this, though most of it will have to wait until #5362, #5363, and #5229 are resolved. Once #5362 is complete, I'm happy to start refactoring...

Avoid certain panics in decoding.

The change to `Source` sounds good. I'm curious to see how the newtype approach works out -- it can be quite tricky.

Undocumented config feature not in the docs: overwrite_null

Should the documentation basically just be "These config options allow overwriting blank metadata fields for albums or tracks"?

Undocumented config feature not in the docs: overwrite_null

Solved by #5373.

Update annotations from Python 3.8 support

I'd like to help with this. I see that the main idea is to use `list` / `dict` / `tuple` wherever possible instead of the `typing.*` aliases -- are there...