beets icon indicating copy to clipboard operation
beets copied to clipboard

Fix the no_convert option of the convert plugin stopping conversion when there is only a partial match.

Open sanpoChew opened this issue 6 months ago • 5 comments

Description

I was running the convert plugin with the following config:

no_convert: samplerate:..48000 bitdepth:..16

but anything that was 24/48 was also not being converted, this was due to the code returning False for should_transcode if any part of the query matches, rather than considering the whole query. This meant that bitdepth:...16 was being ignored.

I have changed this so the no_convert value is considered as one query.

To Do

  • [X] ~Documentation.~
  • [X] Changelog.
  • [X] Tests.

sanpoChew avatar Aug 01 '24 08:08 sanpoChew