Chris Ward
Chris Ward
@Rarst Oh! I see what you mean. Since we actually look at all three of these fields: ```json "weapon_category": "Martial", "weapon_range": "Melee", "category_range": "Martial Melee", ``` Which is a way...
This would also let us free up some other fields like `armor_category`.
Oh right. We were just renaming that to `range`? ```json { "index": "trident", "name": "Trident", "equipment_categories": [{ "index": "weapon", "name": "Weapon", "url": "/api/equipment-categories/weapon" }, { "index": "martial-melee-weapons", "name": "Martial Melee...
@fergcb What do you think?
You could maybe tuck it into `range`: ```json "range": { "normal": 20, "long": 60, "reach": 10, } ``` That might make the most sense. Though might be weird? But that...
Some of this is probably related to https://github.com/5e-bits/5e-database/issues/397 However, the properties would be a nice addition. I'm here for it.
@Redmega Do you think this would be more useful on the `/api/equipment` route? Putting it on the `/api/equipment-categories/weapon` route seems odd.
I've been considering adding an `equipment_categories` field that has an array of all categories that apply to an equipment. Then we don't have 3-4 different fields like we do right...
This caused an issue with the DB repo. I think it's not ready to upgrade to yet.
@ThomasGCarpenter Can you look into why your tests are failing?