5e-srd-api
5e-srd-api copied to clipboard
feat: Query equipment-category/weapons by property
What does this do?
On the equipment-categories route, one can now filter weapons by weapon properties.
How was it tested?
Manually tested various http requests for equipment-categories on Postman successfully. Followed swagger README instructions to set up local development environment which ran successfully after adding new openapi documentation.
Is there a Github issue this is resolving?
Yes, this resolves issue #232
Was any impacted documentation updated to reflect this change?
Yes, I updated the swagger documentation according to the guidelines found in the swagger README.
Here's a fun image for your troubles
@ThomasGCarpenter Can you look into why your tests are failing?
All the tests have now passed @bagelbits
Sorry. I think I misunderstood what this PR was trying to do. You're altering the /api/equipment_category/${index}
route to filter the weapons that are returned with it by property
?
You could maybe do something with /api/equipment
route that would make a bit more sense. Alternatively, you can easily do this query with the GraphQL endpoint.