Alexey Bader

Results 168 comments of Alexey Bader

> It would be interesting to have a test checking that if we have a user-provided `sycl.hpp` `#include ` or `#include "sycl.hpp" can include this file. This sounds like a...

@alexbatashev, please, address code review comments and merge conflicts.

Timed Out : 8 Failed : 1 Do you know what might cause this issue?

> One failed test is a known issue Is it related to this change? If no, please, disable the failing test to avoid false alarms. > 8 timed out tests...

FYI. I see something related in pre-commit for https://github.com/intel/llvm/pull/5778. See https://github.com/intel/llvm/runs/5496313460?check_suite_focus=true. ******************** Timed Out Tests (7): SYCL :: KernelAndProgram/multiple-kernel-linking.cpp SYCL :: Plugin/level_zero_batch_test.cpp SYCL :: Plugin/level_zero_batch_test_copy_with_compute.cpp SYCL :: Plugin/retain_events.cpp SYCL ::...

Another one - https://github.com/intel/llvm/runs/5496822497?check_suite_focus=true. It looks like a regression introduced before your patch.

@againull, we reviewed recent changes we made to the `sycl` branch and identified https://github.com/intel/llvm/pull/5231 as one of the changes that might cause the timeout issues discussed above. Could you check...

Another instance: https://github.com/intel/llvm/runs/5503076361?check_suite_focus=true. Pre-commit for https://github.com/intel/llvm/pull/5772.

A different picture here: https://github.com/intel/llvm/runs/5504737044?check_suite_focus=true ``` 600.02s: SYCL :: ESIMD/kmeans/kmeans.cpp 595.17s: SYCL :: ESIMD/matrix_transpose_glb.cpp 592.98s: SYCL :: ESIMD/matrix_transpose_usm.cpp 591.00s: SYCL :: ESIMD/noinline_args_size/noinline_args_char_int_size_192.cpp 590.90s: SYCL :: ESIMD/noinline_args_size/noinline_args_char_int_size_512.cpp 590.84s: SYCL :: ESIMD/noinline_args_size/noinline_args_char_int_size_256.cpp...

> What needs to happen next? @intel/dpcpp-specification-reviewers is expected to review this proposal.