llvm icon indicating copy to clipboard operation
llvm copied to clipboard

Published 20 hours ago • verified publisher icon intel

[SYCL][Doc] Add improved guidelines for runtime test development

Open alexbatashev opened this issue 3 years ago • 3 comments

New guidelines should provide clear expectations from incoming pull requests and also give hints on how to write tests for particular types of changes.

alexbatashev avatar Feb 07 '22 10:02 alexbatashev

Some improvements for PI Mock framework from these BKMs are not merged yet: https://github.com/intel/llvm/pull/5358

alexbatashev avatar Feb 07 '22 10:02 alexbatashev

It looks good to me but would be good to see more reviews/comments from @intel/llvm-reviewers-runtime who write the tests and expected to be compliant with this doc.

pvchupin avatar Feb 08 '22 22:02 pvchupin

@alexbatashev, please, address code review comments and merge conflicts.

bader avatar Feb 17 '22 11:02 bader