Alexey Bader

Results 166 comments of Alexey Bader

> Hi @bader > > I wanted to get your take on this. I have vetted my change to a certain level. Please let me know if it is agreeable...

> **Similar to upstream LLVM, we expect user to have `zstd-dev` package installed on their machine** - we won't be installing zstd from sources. At the same time, we should...

> I'd like to get some architecture and code-organzation level comments on my SYCL thinLTO prototype. > > The feature isn't ready for code-review, so I'd appreciate keeping the discussion...

> @bader, can you please clarify..'standard LLVM pipeline'? Sorry if the question is too naive. Wanted to check before adding my comments here. Thanks I mean the pipeline built here:...

> Note that spec constants is only one example, but there are (and will be) likely more passes that require fully linked module to work correctly. In my opinion, this...

@sarnex, I've made minor editorial changes, but unfortunately, I can't push them to your branch. Your repository doesn't allow me to create a pull request to your private branch. If...

> For some reason I can't reply inline You can reply inline here: https://github.com/intel/llvm/pull/15083#discussion_r1769334803. When you publish a review with new discussions (1) and replies to already existing discussions (2),...

@MartinWehking, why this change is done only for NVPTX target? Can't we make the same change for other targets as well?

@fwyzard, the problem is `ocloc` tool. `llvm-foreach` just a simple launcher runs commands from a file and waits for them to complete. You can check the logic [here](https://github.com/intel/llvm/blob/sycl/llvm/tools/llvm-foreach/llvm-foreach.cpp#L95) - it's...