Dave Bakker

Results 154 comments of Dave Bakker

My previous post relates to user defined types, but I guess the same can be done for the built-in value type specializations. Suppose the `flags` type didn't exist in ComponentModel1.0...

In the context of WASI, annotations could also be used to hint at the host on how to resolve imports and specify which permissions each import requires. Potentially replacing [external...

All in all, looks good to me 🚀

Having thought about it some more I would like to offer one more suggestion. See code below. This touches multiple discussions above, so tagging @alexcrichton. The main difference is that...

> something like that breaks down unless all callbacks about configuration go through trait Network, so for example we'd also need to route IP address checks through that trait as...

@alexcrichton One of the (many..) changes in this PR is that the actual socket code has been separated out from the component trait implementation to its own `SystemTcpSocket`/`SystemUdpSocket`. To reduce...

Thanks for the feedback. I agree on the "panicky" point. I'll add an error type and remove the panics. One thing that's not in this PR, but I assume will...

I chose to go with a hybrid approach. For the public API, I changed it to what you suggested. Internally, I removed Lease & SlotIdentity. But I kept Slot to...

I think you mean changing ``` async fn ready(&mut self); ``` to ``` async fn ready(&mut self, table: &ResourceTable); ``` right? That doesn;t work because `&ResourceTable` is not Send as...

I understand your concerns, yet I'd rather not go for round three right now, which would include reverting https://github.com/bytecodealliance/wasmtime/pull/7802. So instead, I've changed the questionable types to be private to...