John Backus
John Backus
I would probably be fine with adding some kind of support like you're proposing here but I'd prefer we do a better job recommending people use composable matchers. Maybe you...
Good idea. Might make sense as a separate cop since it sounds like you are talking about more than just detecting the subject being stubbed. `StubbedDescribedClass` maybe?
The `ExampleWording` cop (I think that is the name) already does some checks like this. I have no time to get to this stuff but if you're interested you could...
Interesting. Assuming calling `fit` inside of an example doesn't focus the test then we should definitely stop searching for focusing method calls once we know we are inside of an...
Maybe to catch things like `spec/spec_helper.rb` and `spec/support/` which maybe has example groups in it?
(I'll add explanation here later, just opening this while I'm in the middle of a code review)
If this cop did exist I think it would have to be disabled by default. For example, maybe 80% of the specs for rubocop-rspec use this `expect_violation` helper method I...
That would make it much more manageable I think. Checkout the `CustomInclude` method that `EmptyExampleGroup` uses: https://github.com/backus/rubocop-rspec/blob/master/lib/rubocop/cop/rspec/empty_example_group.rb#L76
I'm open to PRs for this. I have mentioned this in other PRs but I don't plan on implementing rails specific cops. It would also be nice if these things...
As long as capybara support don't get in the way of normal rspec users I guess I'm fine with it. I don't use capybara so I wont be great as...