John Backus

Results 74 comments of John Backus

@ehannes the explicit globs in the config file. IMO we couldn't reliably know what the different spec types are without loading the user's rspec environment and this gem is not...

Yeah I added #233 for that reason

Could this awkwardly clash with the fact that ruby emits a warning if you access an ivar before it is initialized? It seems like this is usually the reason for...

I'm interested in helping implement this. What about a smell name like `ManualDispatch`? A "type check" is a very overloaded term in computer science and it also doesn't totally signify...

Great. Separating these into separate smells detectors makes everything way simpler

@mvz @troessner I've opened https://github.com/troessner/reek/issues/1031 to represent _just_ the manual dispatch part of this issue. This way I wont prematurely close this issue with my small PR

Not really sure if there is a security aspect to this beyond like validating that something is a specific type. Everything responds to `#to_s` and `%s` is still going to...

You should wrap this test in `aggregate_failures`. We just released an improvement that treats aggregated failures as one assertion. Can you let me know if that works for you?

Have you tried writing `raise_error(MyErrorType).with_message(/something went wrong/)`?