backstage icon indicating copy to clipboard operation
backstage copied to clipboard

Add search functionality in MembersListCard [ContribFest]

Open Irma12 opened this issue 9 months ago • 1 comments

Hey, I just made a Pull Request!

Added search functionality in MembersListCard as part of ContribFest (https://github.com/backstage/backstage/issues/27009)

Screenshot 2025-04-03 at 12 03 12 Screenshot 2025-04-03 at 12 03 27

Without showAggregateMembers toggle Screenshot 2025-04-03 at 12 04 05

:heavy_check_mark: Checklist

  • [x] A changeset describing the change and affected packages. (more info)
  • [ ] Added or updated documentation
  • [ ] Tests for new functionality and regression tests for bug fixes
  • [x] Screenshots attached (for UI changes)
  • [x] All your commits have a Signed-off-by line in the message. (more info)

Irma12 avatar Apr 03 '25 11:04 Irma12

[!IMPORTANT] This PR includes changes that affect public-facing API. Please ensure you are adding/updating documentation for new features or behavior.

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage/plugin-org plugins/org minor v0.6.38-next.1

backstage-goalie[bot] avatar Apr 03 '25 11:04 backstage-goalie[bot]

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

github-actions[bot] avatar Apr 22 '25 20:04 github-actions[bot]

Hi @Irma12, @freben, @camilaibs

Hope you're all doing well!

I wanted to check in on this PR. I had initially started exploring this feature during KubeCon 2024 but had to pause, so I was curious about the current direction—specifically, is the search logic intended to remain entirely on the frontend, or are we planning to involve the backend as well?

If backend integration is on the roadmap, I’d love to explore how we can structure that and would be happy to collaborate.

Thanks for driving this forward once again @Irma12

arup-chauhan avatar Apr 22 '25 21:04 arup-chauhan

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

github-actions[bot] avatar May 06 '25 21:05 github-actions[bot]

I think client side is fine for now - we are just waiting to see if @Irma12 comes back with feedback / fixes

freben avatar May 13 '25 12:05 freben

I think client side is fine for now - we are just waiting to see if @Irma12 comes back with feedback / fixes

@freben If needed, I can contribute again for the fest, I have just wrapped up my semester so have some time now.

I guess last we needed was filter length and the test set. @camilaibs @Irma12, please let me know if I can go ahead!

arup-chauhan avatar May 14 '25 21:05 arup-chauhan

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

github-actions[bot] avatar May 28 '25 21:05 github-actions[bot]

@camilaibs @freben just wanted to have a quick follow-up can I work on this? I can open a new PR if needed.

arup-chauhan avatar Jul 11 '25 06:07 arup-chauhan

@camilaibs @freben just wanted to have a quick follow-up can I work on this? I can open a new PR if needed.

@Arup-Chauhan sure! Assigned to you given the closure of original context on June 4th - thanks for volunteering to work on this!

MihaiTabara avatar Jul 21 '25 14:07 MihaiTabara

@camilaibs @freben just wanted to have a quick follow-up, can I work on this? I can open a new PR if needed.

@Arup-Chauhan sure! Assigned to you, given the closure of the original context on June 4th - thanks for volunteering to work on this!

Hi Mihai, thanks for this. I have cherry-picked the previous changes in my own fork and am working on it. Will keep you all posted.

arup-chauhan avatar Jul 23 '25 02:07 arup-chauhan

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

github-actions[bot] avatar Aug 06 '25 03:08 github-actions[bot]

Hi @MihaiTabara @freben @camilaibs , I’ve made some related updates on my feature/add-search-members branch and would like to contribute them here so the PR doesn’t go stale.

Would you prefer I push directly to add-search-to-entity-members-card (if I have access) or open a new PR targeting this branch?

I’m fine with either, but I’d slightly prefer the latter so you can review it easily.

arup-chauhan avatar Aug 06 '25 03:08 arup-chauhan

Hi @MihaiTabara @freben @camilaibs , I’ve made some related updates on my feature/add-search-members branch and would like to contribute them here so the PR doesn’t go stale.

Would you prefer I push directly to add-search-to-entity-members-card (if I have access) or open a new PR targeting this branch?

I’m fine with either, but I’d slightly prefer the latter so you can review it easily.

Hi @Arup-Chauhan, thanks again for your contribution 🙏🏻 ! Please open a new pull request and share the link here. Then I'll close this one by linking to your new pull request 🙂

camilaibs avatar Aug 12 '25 11:08 camilaibs

Hi @MihaiTabara @freben @camilaibs , I’ve made some related updates on my feature/add-search-members branch and would like to contribute them here so the PR doesn’t go stale. Would you prefer I push directly to add-search-to-entity-members-card (if I have access) or open a new PR targeting this branch? I’m fine with either, but I’d slightly prefer the latter so you can review it easily.

Hi @Arup-Chauhan, thanks again for your contribution 🙏🏻 ! Please open a new pull request and share the link here. Then I'll close this one by linking to your new pull request 🙂

Hello @camilaibs , thanks for responding, I opened a new draft PR #30833 and asked a question there, would be great if you can help me there!

See you there!

arup-chauhan avatar Aug 14 '25 04:08 arup-chauhan

Closing this in favor the https://github.com/backstage/backstage/pull/30833. Thank you @Irma12 for starting this contribution, your are more than welcome to help us review the new pull request 🙂

camilaibs avatar Aug 14 '25 08:08 camilaibs