refactor(users): Move hardcoded email subjects to constants

[nick-gray-bah]

Type of Change

• [ ] Bugfix
• [ ] New feature
• [ ] Enhancement
• [x] Refactoring
• [ ] Dependency updates
• [ ] Documentation
• [ ] CI/CD

Description

Change the hardcoded email subject to constants

Additional Changes

• [ ] This PR modifies the API contract
• [ ] This PR modifies the database schema
• [ ] This PR modifies application configuration/environment variables

Motivation and Context

refactor based on this issue - #5940 link Closes #5940.

How did you test it?

change_apply_before.txt change_apply_after.txt

Checklist

• [x] I formatted the code cargo +nightly fmt --all
• [x] I addressed lints thrown by cargo clippy
• [x] I reviewed the submitted code
• [ ] I added unit tests for my changes where possible

[semanticdiff-com[bot]]

Review changes with SemanticDiff.

Analyzed 6 of 6 files.

Overall, the semantic diff is 12% smaller than the GitHub diff.

	Filename	Status
:heavy_check_mark:	crates/router/src/consts.rs	Analyzed
:heavy_check_mark:	crates/router/src/workflows/api_key_expiry.rs	3.39% smaller
:heavy_check_mark:	crates/router/src/services/email/types.rs	Analyzed
:heavy_check_mark:	crates/router/src/core/recon.rs	35.45% smaller
:heavy_check_mark:	crates/router/src/core/user.rs	13.43% smaller
:heavy_check_mark:	crates/router/src/consts/user.rs	Analyzed

[ThisIsMani]

Fix the PR title and link the issue. I'll approve the workflow.

[SummerGram]

What is the title of the PR supposed be?

[SummerGram]

@ThisIsMani

I link the issue in the motivation and context part but I still cannot pass the check.

[SummerGram]

@ThisIsMani Please review the change.

[SummerGram]

@ThisIsMani

Why is it failed to run?

[ThisIsMani]

Please recheck the variables again.

[SummerGram]

Please recheck the variables again.

Those failure in ci-pr is related to the variables name?

[ThisIsMani]

You code is not compiling. That's why the run is failed.

You can check by running just check.

[SummerGram]

You code is not compiling. That's why the run is failed.

You can check by running just check.

Thanks!

[SummerGram]

Hi @ThisIsMani ,

I think "clonable" typo is not related to this PR.

[SanchithHegde]

I think "clonable" typo is not related to this PR.

You can ignore that, shouldn't be a problem. Moreover, it's not a required check, so it shouldn't block your PR from being merged.