backstage icon indicating copy to clipboard operation
backstage copied to clipboard

Published 20 hours ago • verified publisher icon backstage

Declarative CLI Templates

Open minkimcello opened this issue 1 year ago • 3 comments

Hey, I just made a Pull Request!

Remaining TODOs

  • [ ] Read templates from a URL
  • [ ] Compose names for modules with id prompt
  • [ ] Prompt validators? (see comment)
  • [ ] Automatically install packages to backend/app? (see comment)

:heavy_check_mark: Checklist

  • [ ] A changeset describing the change and affected packages. (more info)
  • [ ] Added or updated documentation
  • [ ] Tests for new functionality and regression tests for bug fixes
  • [ ] Screenshots attached (for UI changes)
  • [ ] All your commits have a Signed-off-by line in the message. (more info)

minkimcello avatar Sep 21 '24 11:09 minkimcello

Missing Changesets

The following package(s) are changed by this PR but do not have a changeset:

  • @backstage/cli

See CONTRIBUTING.md for more information about how to add changesets.

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage/cli packages/cli none v0.28.0-next.0

backstage-goalie[bot] avatar Sep 21 '24 11:09 backstage-goalie[bot]

  • I didn't include any CLI flag options. I assume things like private, npm-registry, and license can now be written right into the template. Or if these templates are used by companies that have teams that need to configure separate registries, they could always make that a required prompt.
  • Do we still want to accommodate for Lerna users for setting the base version?
  • I was thinking of having newly created packages be automatically installed to the backend or the app depending on the role specified in package.json. Thoughts?
  • Should I look for a way for users to be able to provide validators for their prompts? I have the default validator used for plugin and module id prompt as a placeholder, but clearly that validator won't apply to every use-case.

minkimcello avatar Sep 21 '24 17:09 minkimcello

Regarding lerna, yeah we can remove that. Thinking we just make it a global option instead

Rugvip avatar Sep 23 '24 20:09 Rugvip

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

github-actions[bot] avatar Oct 13 '24 20:10 github-actions[bot]

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

github-actions[bot] avatar Oct 28 '24 07:10 github-actions[bot]

Are there any chances this can be re-opened? Sounds like a cool feature!

alper98 avatar Nov 11 '24 08:11 alper98

@minkimcello we can't re-open this PR, can you create a new one? :pray:

benjdlambert avatar Nov 21 '24 11:11 benjdlambert

@minkimcello we can't re-open this PR, can you create a new one? 🙏

@benjdlambert Ah okay. Sure 👍

minkimcello avatar Nov 21 '24 13:11 minkimcello

Hi @minkimcello, do you happen to have a rough ETA on the new PR to keep moving this forward?

awanlin avatar Nov 28 '24 14:11 awanlin

@awanlin @benjdlambert @Rugvip #27934 i just rebased and opened up a new PR. i'll put some more time into it this weekend.

minkimcello avatar Nov 29 '24 15:11 minkimcello