backstage icon indicating copy to clipboard operation
backstage copied to clipboard
verified publisher icon backstage

feat(gerrit-urlreader): support fetching content for a commit SHA hash

Open anicke opened this issue 1 year ago • 2 comments

Hey, I just made a Pull Request!

A follow up to #25202 that brings support to the GerritUrlReader to get content referenced by a full SHA hash. The intended use cases is auxiliary helpers to support users creating/updating catalog files. One example is API validation as stated in #25733.

:heavy_check_mark: Checklist

  • [X] A changeset describing the change and affected packages. (more info)
  • [ ] Added or updated documentation
  • [X] Tests for new functionality and regression tests for bug fixes
  • [ ] Screenshots attached (for UI changes)
  • [X] All your commits have a Signed-off-by line in the message. (more info)

anicke avatar Sep 20 '24 13:09 anicke

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage/backend-defaults packages/backend-defaults patch v0.7.0-next.0
@backstage/integration packages/integration patch v1.16.0

backstage-goalie[bot] avatar Sep 20 '24 13:09 backstage-goalie[bot]

Yes, I agree about deprecating those functions. No point in having those around since they are not use any more.

anicke avatar Sep 26 '24 12:09 anicke

Not stale!

anicke avatar Oct 09 '24 08:10 anicke

Not stale bump!

anicke avatar Oct 21 '24 08:10 anicke

@Rugvip Could you take a look?

anicke avatar Oct 21 '24 12:10 anicke

not stale bump

anicke avatar Oct 28 '24 08:10 anicke

not stale!

anicke avatar Nov 11 '24 08:11 anicke

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

github-actions[bot] avatar Nov 25 '24 08:11 github-actions[bot]

Not stale! @Rugvip could you have a look?

anicke avatar Nov 25 '24 09:11 anicke

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

github-actions[bot] avatar Dec 09 '24 09:12 github-actions[bot]

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

github-actions[bot] avatar Dec 31 '24 12:12 github-actions[bot]

bump, not stale

anicke avatar Jan 07 '25 12:01 anicke

Thank you for contributing to Backstage! The changes in this pull request will be part of the 1.35.0 release, scheduled for Tue, 14 Jan 2025.

github-actions[bot] avatar Jan 14 '25 07:01 github-actions[bot]