backstage icon indicating copy to clipboard operation
backstage copied to clipboard

support negation of full text search

Open mbenson opened this issue 1 year ago • 7 comments

Hey, I just made a Pull Request!

Support negation of full text search in /entities/by-query of catalog API.

:heavy_check_mark: Checklist

  • [X] A changeset describing the change and affected packages. (more info)
  • [ ] Added or updated documentation
  • [X] Tests for new functionality and regression tests for bug fixes
  • [ ] Screenshots attached (for UI changes)
  • [X] All your commits have a Signed-off-by line in the message. (more info)

mbenson avatar Jun 26 '24 15:06 mbenson

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage/plugin-catalog-backend plugins/catalog-backend minor v1.25.0

backstage-goalie[bot] avatar Jun 26 '24 15:06 backstage-goalie[bot]

Thank you! 🙏 Could you share more about the use case needed for this feature?

vinzscam avatar Jun 28 '24 20:06 vinzscam

I have a set of entities I import from an external system, and they are tagged with their location in that external system. But if I need to update them to a new instance of said system I need to be able to search for the entities with X characteristic and where a certain label value does not match a LIKE pattern.

mbenson avatar Jun 28 '24 20:06 mbenson

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

github-actions[bot] avatar Jul 12 '24 20:07 github-actions[bot]

@vinzscam your thoughts?

mbenson avatar Jul 13 '24 18:07 mbenson

Hi! We discussed it some time ago and I hoped to get back with a plan but then vacations started.

My take is that the current filters have some historical baggage and drawbacks that makes me hesitant to pull in any further features on top of them. Instead, we may want to start drawing up a bigger picture refactor of what the future of filtering should look like, some time down the line, allowing for improvements like this to be added on top.

We'll give it some more discussion later on and get back.

freben avatar Jul 13 '24 18:07 freben

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

github-actions[bot] avatar Aug 21 '24 11:08 github-actions[bot]

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

github-actions[bot] avatar Sep 20 '24 10:09 github-actions[bot]