backstage icon indicating copy to clipboard operation
backstage copied to clipboard

Creating draft PR for working on issue 25011

Open arup-chauhan opened this issue 1 year ago • 3 comments

Hey, I just made a Pull Request!

@vinzscam @piatkiewicz , I have created this PR for working on the issue: https://github.com/backstage/backstage/issues/25011

Will fill up the details as I continue to work. Thanks for the support so far guys!

:heavy_check_mark: Checklist

  • [ ] A changeset describing the change and affected packages. (more info)
  • [ ] Added or updated documentation
  • [ ] Tests for new functionality and regression tests for bug fixes
  • [ ] Screenshots attached (for UI changes)
  • [ ] All your commits have a Signed-off-by line in the message. (more info)

arup-chauhan avatar Jun 14 '24 11:06 arup-chauhan

Thanks for the contribution! All commits need to be DCO signed before they are reviewed. Please refer to the the DCO section in CONTRIBUTING.md or the DCO status for more info.

backstage-goalie[bot] avatar Jun 14 '24 11:06 backstage-goalie[bot]

Update: found the issue in the Router component, working on resolving it soon to fix issue: #25011

arup-chauhan avatar Jun 25 '24 09:06 arup-chauhan

Hi! For issue #25011
I'm currently working on setting up routing for some components within a <MemoryRouter> tag. Specifically, I'm trying to provide the correct routing context for the AggregateMembersToggle and Default

While it makes sense to use GroupProfileCard as an element within the route, it leads to issues with permission hooks

Any feedback or direction on:

  • The appropriate routing tags and structure within <MemoryRouter> to provide context.

  • Is it the right to integrate GroupProfileCard? If yes how we do it without permission issues.

  • Any additional components or mock implementations needed to resolve these issues.

@Rugvip @camilaibs @iamEAP @freben @vinzscam , I would really appreciate any sort of help on this.

arup-chauhan avatar Jun 28 '24 11:06 arup-chauhan

Hi! For issue #25011 I'm currently working on setting up routing for some components within a tag. Specifically, I'm trying to provide the correct routing context for the AggregateMembersToggle and Default

While it makes sense to use GroupProfileCard as an element within the route, it leads to issues with permission hooks

Any feedback or direction on:

  • The appropriate routing tags and structure within to provide context.
  • Is it the right to integrate GroupProfileCard? If yes how we do it without permission issues.
  • Any additional components or mock implementations needed to resolve these issues.

@Rugvip @camilaibs @iamEAP @freben @vinzscam , I would really appreciate any sort of help on this.

Replied here: https://github.com/backstage/backstage/issues/25011#issuecomment-2211681184

camilaibs avatar Jul 06 '24 06:07 camilaibs

Hi all, I am marking this PR ready for review, this fixes issue #25011

As suggested by @camilaibs , I have added the TestApp for giving missing routing context and removed the MemoryRouter to avoid conflicts.

The issue is fixed, the Group Member List Card components are properly coming up now.

Thanks @vinzscam @piatkiewicz for help

Tagging a few maintainers for review @Rugvip @mtlewis @benjdlambert

P.S: I have added the signoff, I still don't know why DCO sign-off check for the commit is failing, rest all is good. Please let me know if anything else is needed to be done, cheers!

Refrence images added.

Screenshot 2024-07-21 004102 Screenshot 2024-07-21 004056 Screenshot 2024-07-21 004050

arup-chauhan avatar Jul 21 '24 06:07 arup-chauhan