backstage icon indicating copy to clipboard operation
backstage copied to clipboard

Fix template prettier issues

Open tudi2d opened this issue 1 year ago • 3 comments

When working on the backstage/community-plugins repository & trying out the templates I ran into issues with yarn prettier:check. This PR adresses issues in the default templates. I created the plugins/modules, ran yarn prettier:check, ran prettier on the files with warnings & the copied the fixes over to the templates.

Initial commit where I ran into the issue: https://github.com/backstage/community-plugins/pull/13/commits/48d9560ec3348aebac0ad0f46f284aab10d1b1a8

:heavy_check_mark: Checklist

  • [ ] A changeset describing the change and affected packages. (more info)
  • [ ] Added or updated documentation
  • [ ] Tests for new functionality and regression tests for bug fixes
  • [ ] Screenshots attached (for UI changes)
  • [ ] All your commits have a Signed-off-by line in the message. (more info)

tudi2d avatar Feb 21 '24 14:02 tudi2d

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage/cli packages/cli patch v0.25.2

backstage-goalie[bot] avatar Feb 21 '24 14:02 backstage-goalie[bot]

Uffizzi Cluster pr-23139 was deleted.

github-actions[bot] avatar Feb 21 '24 14:02 github-actions[bot]

A potentially interesting side note - create-plugin actually explicitly runs a yarn lint --fix as part of creation! I wonder if that type of thing could make sense in the other commands too ... ping @Rugvip

freben avatar Feb 21 '24 16:02 freben

Thank you for contributing to Backstage! The changes in this pull request will be part of the 1.24.0 release, scheduled for Tue, 19 Mar 2024.

github-actions[bot] avatar Feb 28 '24 13:02 github-actions[bot]