backstage icon indicating copy to clipboard operation
backstage copied to clipboard

Inconsistency in Styling and Title Visibility for Top Visited and Recently Visited Cards

Open zeshanziya opened this issue 1 year ago • 4 comments

Hey, I just made a Pull Request!

Please see Issue #23096

Changes:

Modified the VisitList component to ensure proper rendering of the card title. Integrated the title from createCardExtension in plugin.ts to maintain consistency with other cards on the home page.

:heavy_check_mark: Checklist

Old UI old

New UI: new

  • [x] A changeset describing the change and affected packages. (more info)
  • [] Added or updated documentation
  • [x] Tests for new functionality and regression tests for bug fixes
  • [x] Screenshots attached (for UI changes)
  • [x] All your commits have a Signed-off-by line in the message. (more info)

zeshanziya avatar Feb 20 '24 13:02 zeshanziya

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage/plugin-home plugins/home minor v0.6.3-next.0

backstage-goalie[bot] avatar Feb 20 '24 13:02 backstage-goalie[bot]

Uffizzi Cluster pr-23097 was deleted.

github-actions[bot] avatar Feb 20 '24 13:02 github-actions[bot]

I see some test cases are failing as title is being used everywhere. I am working on this and fix it asap.

zeshanziya avatar Feb 21 '24 04:02 zeshanziya

Is it possible to review this PR please ! This is a blocker for ones who to translates their app. As and example if you customize the titles in the HomePage.tsx titles gets duplicated in the UI.

image

The changes made by @zeshanziya fix this issue.

image

fjudith avatar Feb 23 '24 09:02 fjudith

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

github-actions[bot] avatar Mar 02 '24 01:03 github-actions[bot]

Hi @callebstrom, have you had a chance to review the PR? Please let me know if you need any additional information from my side.

zeshanziya avatar Mar 04 '24 02:03 zeshanziya

Thank you for contributing to Backstage! The changes in this pull request will be part of the 1.24.0 release, scheduled for Tue, 19 Mar 2024.

github-actions[bot] avatar Mar 07 '24 16:03 github-actions[bot]