backstage icon indicating copy to clipboard operation
backstage copied to clipboard

feat: initiate EventBroker as service instead extension

Open drodil opened this issue 1 year ago • 7 comments

Hey, I just made a Pull Request!

this allows to use eventbroker as a dependency in plugins like signals. also having it as an extension is dangerous as it might be overwritten by different plugins; instead if an application wants to use different broker, it can replace the default service factory.

:heavy_check_mark: Checklist

  • [x] A changeset describing the change and affected packages. (more info)
  • [x] Added or updated documentation
  • [x] Tests for new functionality and regression tests for bug fixes
  • [ ] Screenshots attached (for UI changes)
  • [x] All your commits have a Signed-off-by line in the message. (more info)

drodil avatar Feb 06 '24 11:02 drodil

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage/plugin-events-backend plugins/events-backend patch v0.2.19-next.1
@backstage/plugin-events-node plugins/events-node patch v0.2.19-next.1
@backstage/plugin-signals-backend plugins/signals-backend patch v0.0.1-next.1
@backstage/plugin-signals-node plugins/signals-node patch v0.0.1-next.1

backstage-goalie[bot] avatar Feb 06 '24 11:02 backstage-goalie[bot]

@drodil I have already worked on PR #22344

pjungermann avatar Feb 06 '24 12:02 pjungermann

@drodil I have already worked on PR #22344

Hah, great 👍 Didn't see that, just wanted to fill in the cap with the signals service so made this 😆

drodil avatar Feb 06 '24 12:02 drodil

Uffizzi Ephemeral Environment - Virtual Cluster

Your cluster pr-22762 was successfully created. Learn more about Uffizzi virtual clusters To connect to this cluster, follow these steps:

  1. Download and install the Uffizzi CLI from https://docs.uffizzi.com/install
  2. Login to Uffizzi, then select the backstage account and project:
uffizzi login
Select an account: 
  ‣ backstage
    jdoe

Select a project or create a new project: 
  ‣ backstage-6783521
  1. Update your kubeconfig: uffizzi cluster update-kubeconfig pr-22762 --kubeconfig=[PATH_TO_KUBECONFIG] After updating your kubeconfig, you can manage your cluster with kubectl, kustomize, helm, and other tools that use kubeconfig files: kubectl get namespace --kubeconfig [PATH_TO_KUBECONFIG]

Access the backstage endpoint at https://backstage-default-pr-22762-c3191.uclusters.app.uffizzi.com

github-actions[bot] avatar Feb 06 '24 12:02 github-actions[bot]

Yes, I had the signals plugin also on my radar. We need to add event support to other event users like some catalog modules as well. I've planned to work on this as a follow-up whenever that PR is settled. 👍

Would be great if you could share your thoughts and feedback at the other PR, too.

pjungermann avatar Feb 06 '24 12:02 pjungermann

Yes, I had the signals plugin also on my radar. We need to add event support to other event users like some catalog modules as well. I've planned to work on this as a follow-up whenever that PR is settled. 👍

Would be great if you could share your thoughts and feedback at the other PR, too.

Awesome! I will check the other PR. This PR is on the other hand, backward compatible with the previous EventBroker implementation so external plugins would not need to migrate. But if it's in the plans, then those plugins just have to live with it.

drodil avatar Feb 06 '24 12:02 drodil

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

github-actions[bot] avatar Feb 13 '24 12:02 github-actions[bot]