backstage icon indicating copy to clipboard operation
backstage copied to clipboard

cli: allow supplying additional test file patterns to eslint-factory

Open mtlewis opened this issue 2 years ago • 2 comments

Hey, I just made a Pull Request!

This addition makes life a little easier for folks using different test file patterns (e.g. putting tests or test support files in __tests__ directories), by allowing them to supply additional test file patterns when calling eslint-factory:

module.exports = require('@backstage/cli/config/eslint-factory')(__dirname, {
  testFilePatterns: ['src/**/__tests__/**']
});

:heavy_check_mark: Checklist

  • [x] A changeset describing the change and affected packages. (more info)
  • [ ] Added or updated documentation
  • [ ] Tests for new functionality and regression tests for bug fixes
  • [ ] Screenshots attached (for UI changes)
  • [x] All your commits have a Signed-off-by line in the message. (more info)

mtlewis avatar Sep 09 '22 12:09 mtlewis

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage/cli packages/cli patch v0.20.0-next.0

github-actions[bot] avatar Sep 09 '22 12:09 github-actions[bot]

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If you are the author and the PR has been closed, feel free to re-open the PR and continue the contribution!

github-actions[bot] avatar Sep 21 '22 21:09 github-actions[bot]

@jhaals / @Rugvip I can take a look at doing this - it's a little more involved because it means we have to detect exclusion expressions and break them up in order to handle building absolute paths in the import/no-extraneous-dependencies rule. I think it's probably worth doing though, since right now the parameter won't work correctly with exclusions which could be surprising.

mtlewis avatar Sep 22 '22 21:09 mtlewis

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If you are the author and the PR has been closed, feel free to re-open the PR and continue the contribution!

github-actions[bot] avatar Sep 30 '22 07:09 github-actions[bot]

Just pushed 95cbc6de94 which makes the suggested change, including breaking up negations and converting them to absolute as expected.

mtlewis avatar Sep 30 '22 08:09 mtlewis

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If you are the author and the PR has been closed, feel free to re-open the PR and continue the contribution!

github-actions[bot] avatar Oct 10 '22 09:10 github-actions[bot]

Feeling we should move forward with #14065, alright to close this?

Rugvip avatar Oct 12 '22 10:10 Rugvip

Works for me 👍

mtlewis avatar Oct 13 '22 04:10 mtlewis