backstage
backstage copied to clipboard
cli: allow supplying additional test file patterns to eslint-factory
Hey, I just made a Pull Request!
This addition makes life a little easier for folks using different test file patterns (e.g. putting tests or test support files in __tests__
directories), by allowing them to supply additional test file patterns when calling eslint-factory:
module.exports = require('@backstage/cli/config/eslint-factory')(__dirname, {
testFilePatterns: ['src/**/__tests__/**']
});
:heavy_check_mark: Checklist
Changed Packages
Package Name | Package Path | Changeset Bump | Current Version |
---|---|---|---|
@backstage/cli | packages/cli | patch | v0.20.0-next.0 |
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If you are the author and the PR has been closed, feel free to re-open the PR and continue the contribution!
@jhaals / @Rugvip I can take a look at doing this - it's a little more involved because it means we have to detect exclusion expressions and break them up in order to handle building absolute paths in the import/no-extraneous-dependencies
rule. I think it's probably worth doing though, since right now the parameter won't work correctly with exclusions which could be surprising.
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If you are the author and the PR has been closed, feel free to re-open the PR and continue the contribution!
Just pushed 95cbc6de94 which makes the suggested change, including breaking up negations and converting them to absolute as expected.
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If you are the author and the PR has been closed, feel free to re-open the PR and continue the contribution!
Feeling we should move forward with #14065, alright to close this?
Works for me 👍