backstage
backstage copied to clipboard
feat(playlists): implement playlist plugin
Signed-off-by: Phil Kuang [email protected]
Hey, I just made a Pull Request!
(Apologies for the giant change here 😅)
I put together an implementation of my playlist idea from #6063 but generalized for all entities. Check out the READMEs and demo below for more details!
https://user-images.githubusercontent.com/6998196/181414962-d7a03506-bc95-4a7d-8576-3740e6fde6d9.mov
Potential Future Enhancements
- Clean up of stale entities refs (deleted entities that are still referenced by playlists)
- UI customization for integrators
- Playlist search collator /
ResultListItem
to add playlists to search - More metadata to improve discoverability of useful playlists eg. tags?
- Pagination to support scaling
- Distributed edits / conflict resolution support (if we want to get fancy 😁)
:heavy_check_mark: Checklist
Changed Packages
Package Name | Package Path | Changeset Bump | Current Version |
---|---|---|---|
example-app | packages/app | none | v0.2.75-next.3 |
example-backend | packages/backend | none | v0.2.75-next.3 |
@backstage/core-components | packages/core-components | patch | v0.11.1-next.3 |
@backstage/plugin-playlist-backend | plugins/playlist-backend | minor | v0.0.0 |
@backstage/plugin-playlist-common | plugins/playlist-common | minor | v0.0.0 |
@backstage/plugin-playlist | plugins/playlist | minor | v0.0.0 |
@backstage/plugin-search-react | plugins/search-react | patch | v1.1.0-next.2 |
Hey @kuangp sorry I was holding off reviewing this as had a few other bits going on, will get to it this week! :pray:
Just a quick pass right now, but I'm wondering about the naming of the plugin.
playlist
is a bit ambiguous. Not sure 🤷 @backstage/maintainers?
perhaps entity-playlist
?
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If you are the author and the PR has been closed, feel free to re-open the PR and continue the contribution!
@benjdlambert @Rugvip quick reminder that this is still here awaiting further feedback 😁
@kuangp yep sorry, on my radar! It's a big one so needs a bigger chunk of time, which I haven't sliced out just yet 😅
@kuangp yep sorry, on my radar! It's a big one so needs a bigger chunk of time, which I haven't sliced out just yet 😅
no worries! just want to make sure this doesn't go stale 😄
@Rugvip updated based on your feedback! let me know what you think 🙂
@Rugvip updated !
cc: @iamEAP @emmaindal and the techdocs folks if you guys can take a look when you get the chance please 🙏 Would love to get this in for the next stable release 😁
@camilaibs updated based on your suggestion, thanks for taking a look!
@kuangp this is amazing addition ❤️
Excited for the release 😉