backstage icon indicating copy to clipboard operation
backstage copied to clipboard

Added getSystemIcons() function to the AppManager

Open awanlin opened this issue 2 years ago • 2 comments

Signed-off-by: Andre Wanlin [email protected]

Hey, I just made a Pull Request!

Added getSystemIcons() function to the AppManager that will pull a list of all the icons that have been registered in the App.

This PR also includes documentation updates on how to add more icons beyond those that come by default

:heavy_check_mark: Checklist

  • [x] A changeset describing the change and affected packages. (more info)
  • [x] Added or updated documentation
  • [ ] Tests for new functionality and regression tests for bug fixes
  • [x] Screenshots attached (for UI changes)
  • [x] All your commits have a Signed-off-by line in the message. (more info)

awanlin avatar Jul 18 '22 13:07 awanlin

Unexpected Changesets

The following changeset(s) reference packages that have not been changed in this PR:

  • .changeset/hungry-dogs-agree.md: @backstage/core-plugin-api

Note that only changes that affect the published package require changesets, for example changes to tests and storybook stories do not require changesets.

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage/core-app-api packages/core-app-api patch v1.0.5

github-actions[bot] avatar Jul 18 '22 13:07 github-actions[bot]

Hi @backstage/reviewers, no rush on this but wanted to mention I'm very open to changes. Not totally sure the Settings area is best for this but can't find a better place. Also, for the docs changes I wasn't sure if it should be in a brand new section just on icons or with the theme docs, happy to move this if there are better suggestions. Thanks in advance!

awanlin avatar Jul 18 '22 13:07 awanlin

@awanlin do you wanna fix up the docs conflict here? :pray:

benjdlambert avatar Aug 17 '22 09:08 benjdlambert

@awanlin do you wanna fix up the docs conflict here? 🙏

@benjdlambert Yes, cleaned that up, just waiting for the build to go green. No rush on this, just a heads up I'm away till August 24th

awanlin avatar Aug 17 '22 19:08 awanlin

No probs! Thanks for this :tada:!

benjdlambert avatar Aug 17 '22 19:08 benjdlambert

Thanks @benjdlambert and @Rugvip, hat tip to @kuangp :)

awanlin avatar Aug 24 '22 13:08 awanlin