backstage
backstage copied to clipboard
Added getSystemIcons() function to the AppManager
Signed-off-by: Andre Wanlin [email protected]
Hey, I just made a Pull Request!
Added getSystemIcons()
function to the AppManager
that will pull a list of all the icons that have been registered in the App.
This PR also includes documentation updates on how to add more icons beyond those that come by default
:heavy_check_mark: Checklist
Unexpected Changesets
The following changeset(s) reference packages that have not been changed in this PR:
- .changeset/hungry-dogs-agree.md: @backstage/core-plugin-api
Note that only changes that affect the published package require changesets, for example changes to tests and storybook stories do not require changesets.
Changed Packages
Package Name | Package Path | Changeset Bump | Current Version |
---|---|---|---|
@backstage/core-app-api | packages/core-app-api | patch | v1.0.5 |
Hi @backstage/reviewers, no rush on this but wanted to mention I'm very open to changes. Not totally sure the Settings area is best for this but can't find a better place. Also, for the docs changes I wasn't sure if it should be in a brand new section just on icons or with the theme docs, happy to move this if there are better suggestions. Thanks in advance!
@awanlin do you wanna fix up the docs conflict here? :pray:
@awanlin do you wanna fix up the docs conflict here? 🙏
@benjdlambert Yes, cleaned that up, just waiting for the build to go green. No rush on this, just a heads up I'm away till August 24th
No probs! Thanks for this :tada:!
Thanks @benjdlambert and @Rugvip, hat tip to @kuangp :)