bacalhau icon indicating copy to clipboard operation
bacalhau copied to clipboard

make --download the default

Open lukemarsden opened this issue 2 years ago • 7 comments

then bacalhau docker run ubuntu echo hello will print hello!

lukemarsden avatar Oct 03 '22 19:10 lukemarsden

should still be possible to specify --download=false if you don't want to wait for and download the results

lukemarsden avatar Oct 03 '22 19:10 lukemarsden

@lukemarsden Should this also apply to bacalhau create?

wjam avatar Oct 04 '22 08:10 wjam

No I don't think so, I think the expectation is that bacalhau create works more like kubectl create, which doesn't wait for anything, whereas bacalhau docker run works like docker run which does print stdout (well, stream stdout but close enough)

lukemarsden avatar Oct 04 '22 09:10 lukemarsden

In my opinion I wouldn’t do this. The point of our system is that the stuff is too big to run locally - and it’s hosted in IPFS. If we want small ways to view, huge fan of bacalhau cat or bacalhau ls

aronchick avatar Oct 04 '22 14:10 aronchick

Maybe we could make --wait also print the truncated stdout and err, then make that the default then.

No big data downloads by default, but we still get echo hello works

On Tue, 4 Oct 2022, 15:48 David Aronchick, @.***> wrote:

In my opinion I wouldn’t do this. The point of our system is that the stuff is too big to run locally - and it’s hosted in IPFS. If we want small ways to view, huge fan of bacalhau cat or bacalhau ls

— Reply to this email directly, view it on GitHub https://github.com/filecoin-project/bacalhau/issues/777#issuecomment-1267124535, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACATUVI6UJYZQJEQFA2GGDWBQ7ULANCNFSM6AAAAAAQ34IWLU . You are receiving this because you were mentioned.Message ID: @.***>

lukemarsden avatar Oct 04 '22 21:10 lukemarsden

I agree with @aronchick, this won't work when the datasets are very big Downloading something without the permission of users, is not a good idea

js-ts avatar Oct 06 '22 04:10 js-ts

I don't disagree with printing stdout, I think it should be done by using ipfs cat <CID>/stdout instead of downloading the outputs

js-ts avatar Oct 06 '22 05:10 js-ts

--wait currently prints the truncated stdout and err. Can we close this issue?

wdbaruni avatar Nov 11 '22 03:11 wdbaruni