Dominik Bamberger

Results 21 comments of Dominik Bamberger

I really love the idea of introducing a DSL. Making it optional is a big plus. Especially since I'm not quite sure how to solve the "what are my methods...

I edited a couple of minor things and renamed the command to simply 'discussion', as I thought it was too long otherwise. I also added output for additional commits. However,...

OK, I merged discussion into 'show', since I don't think there are real use cases for having it a separate command. Also, 'show' really gives a very good overview about...

I added the command 'approve' that basically just adds a comment. Eventually, some refactoring will help to close this issue here, too, by just using the already present code. Assigning...

I'd rather have something like `man git-review` or `man git review`, since otherwise I think it's not very obvious and I wonder how many people will find the right command....

Workaround: Pull from origin before using git-review.

If you only have one commit, it does that already. Of you have more, you get a list of your commits. I like the idea of adding switches like -m...

I will change the issue title (to preserve the existing discussion) and add this as a feature request. For the sake of protocol, this is the original title: "fallback pull...

Which switches do we want to implement? I like `-t` for the request's title and `-b` for the request's body / description. Maybe even `--auto` to go with the auto-generated...

OK, so let's go with `-t` and `-b` for the beginning and forget about the rest until we have a real use case for it.