Brendan O'Donnell

Results 20 comments of Brendan O'Donnell

This sounds reasonable but can you add a test for it?

It is still maintained and we're slowly trying to chip away at these older issues. Sorry for letting it languish! If you're still interested could you rebase on master to...

I would agree. There maybe other users of the library that have a valid use case to send to `bob@localhost` for example.

Actually `validate_address` should already reject `blah@example` and `bob@localhost` because they don't have a valid TLD. It will also optionally lookup the MX servers and try to connect to them but...

After discussing this internally we think this also applies similarly to insertions. ``` In [1]: var_c = parse('NM_004985.4:c.567_*1insCCC') In [2]: var_p = c_to_p(var_c) In [3]: str(var_p) Out[3]: 'NP_004976.2:p.(Ter189Ter)' ``` We...

Including `ins` here as per my comment on the related issue.

Thanks for the thorough feedback @reece. I've updated the boundary conditions and tests after reviewing it with @gostachowiak. I believe he'll have a longer update soon. I've also rebased on...

We discovered issues with 2 of the tests I added yesterday. I just pushed a fix for those.

@reece I made some changes based on your feedback but I'm still doing some more testing on my end. I'll comment here once it passes. Thanks!