John Bennewitz comments

Results 5 comments of


                                            John Bennewitz

C++ transitive implementation dependencies should not leak into downstream consumers

Hey y'all! This is valuable to me given the (unfortunate) number of externs across our codebase. Would a fix for this look something like https://github.com/gradle/gradle/compare/master...b-john:transitive_lib_fix ? ```cpp Configuration nativeLink =...

C++ transitive implementation dependencies should not leak into downstream consumers

Looks like with the above proposal, the ordering of the libraries/dependencies becomes necessary though. Before, Gradle was properly ordering my library dependencies correctly but with the above change its on...

C++ transitive implementation dependencies should not leak into downstream consumers

Thanks Daniel-- The thought is if the libraries are static it would be desired behavior to keep as-is/automatically include them in the consuming app? - app A depends on static...

C++ transitive implementation dependencies should not leak into downstream consumers

Sorry, I would further complicate this by your point from 2 years ago: https://github.com/gradle/gradle/issues/801#issuecomment-258258496 If we have bad library design, the static library might have some object files which depend...

C++ transitive implementation dependencies should not leak into downstream consumers

Hey y'all, here's the changes I made to make this work in case it helps: https://github.com/gradle/gradle/compare/master...b-john:ordered_no_trans_deps @lacasseio, interested in your thoughts. I would not expect this to be merged as-is...