zixuan zhao

Results 24 comments of zixuan zhao

It's working as expected now. Please let me know if you have any advice of the implementation. Not sure if I can use sds in .cc, maybe there is better...

Sorry for the delay. I think the code is ready to be reviewed. We also need to verify that the new change addresses the memory issue in #2679. Please let...

Updated. 1. Please let me know if want to keep sds operations in spares path only. We'll need to update string obj after each loop. 2. I think there is...

Updated. 1. Please see my reply to your comment at line 94. 4. The last commit of Hyperloglog.c in my Redis repo is on 11.26.2023. I think it's OK?

Added timestamp_format enum. Use reader friendly role and verbose_level string in logfmt ouput.

```text DEFAULT 42888:M 12 Jan 2024 18:26:34.377 * Server initialized 42888:M 12 Jan 2024 18:26:34.377 * Ready to accept connections tcp LOG_FORMAT_LOGFMT + LOG_TIMESTAMP_DEFAULT pid=43765 role=master timestamp="12 Jan 2024 18:29:14.441"...

Hi @zuiderkwast. Any comment on this PR?

Thanks for your review. Updated.

Hi @madolson. Thanks for review. I just updated my PR based on your suggestions.

> can someone edit the top comment to provide some overview of the differences (examples), as well as justification for this feature? Thanks to @zuiderkwast for updating the top comment....