azu

Results 817 comments of azu

We want to add run time validator for each rule. secretlint-scripts help to integrate it.

Basic impl https://github.com/secretlint/secretlint/tree/master/packages/%40secretlint/secretlint-scripts

Move to https://github.com/secretlint/secretlint/tree/master/archieves/secretlint-scripts

https://web.archive.org/web/20220110130906/https://www.npmjs.com/package/colors https://docs.google.com/spreadsheets/d/1GRtns2mhHCaSiY29HmlHUPrl1h4_Fb0xqScJU_kpcr8/edit#gid=0 FYI: Internet Archive show concrete downloads count.

I created [can-npm-publish](https://github.com/azu/can-npm-publish) for working similar workflow to this RFC. It is hard to maintance this tool because npm v6 and v7 output different format. - [[BUG] NPM 7.x broke...

> Also, my unit tests don't pass with below error: Probably, you need to do`yarn run build` at first. Because, https://github.com/honkit/honkit/tree/master/packages/%40honkit/markdown is migrated to TypeScript by @mizchi. So, `@honkit/markdown/lib/*` is...

> Are we going to follow any strategy like below: Good point! It seems good. We can try this approach in some model as small steps. Addtionaly, We might want...

The pain point of current implementation. The current models class is based on immutable.js. However, It lose TypeScript pros. Because it adds static method to Immutable.js object. Example https://github.com/honkit/honkit/blob/master/packages/honkit/src/models/page.ts ```ts...

- [Immutable.js is essentially unmaintained · Issue #1689 · immutable-js/immutable-js](https://github.com/immutable-js/immutable-js/issues/1689#issuecomment-687239156) - [immutable-js-oss/immutable-js: Immutable persistent data collections for Javascript which increase efficiency and simplicity.](https://github.com/immutable-js-oss/immutable-js)

[Semgrep](https://semgrep.dev/) help us to migration to class. ```yaml rules: - id: model languages: - typescript message: | use class pattern: "const $X = Immutable.Record(...);" fix-regex: regex: 'const (\w+) = ([\s\S]+);'...