Amaury Zarzelli

Thanks for your comments! > In addition, any data built with shortcuts would not work. Thank you for pointing that out, I didn't have that in mind at all. >...

> in src/worker.cc if it is detected that one of these options is set and its not allowed, return a 400 I'm starting to look into that, and I've run...

> the error code should be a 400 because its a request thats invalid. I'm sorry that was unclear, I was mentionning the valhalla error code (as in https://github.com/valhalla/valhalla/blob/master/docs/api/turn-by-turn/api-reference.md#internal-error-codes-and-conditions) Thank...

> 1. as part of the server configuration specify whether these options are to be allowed in a request Added new `service_limits.allow_hard_exclusions` option to server config. https://github.com/valhalla/valhalla/pull/3733/files#diff-941fddb7a7fa73393545caf4c96cb1831af9d79831c4e082d9ee216d228a1a54R260 Defaults to `false`,...

I'm trying to reduce the code used for testing the features, using the gtest `Combine` method, however I'm getting a compilation error that I shouldn't, according to the `Combine` [documentation](http://google.github.io/googletest/reference/testing.html#INSTANTIATE_TEST_SUITE_P)...

I get a similar compilation error using no standard library vectors. ```c++ INSTANTIATE_TEST_SUITE_P(ExcludePropsTest, ExclusionTest, ::testing::Combine(::testing::Values("auto", "taxi", "bus", "truck", "pedestrian", "bicycle", "motor_scooter", "motorcycle" ), ::testing::Values("exclude_bridges", "exclude_tunnels", "exclude_tolls" ) ) ); ```...

I've updated the tests, now there is only one file that tests the feature both when the exclusions are allowed and not allowed on the server.

No worries! It's only natural to do thorough testing when performance could be impacted :wink:

Yes, that's a specific demand from the end users who specifically want to exclude anything that's above ground. The isocurves will be contained in very restricted areas.

I think I'll do the necessary things on a fork anyway because Valhalla is such a great tool for isochrones! I'll submit a pull request when the options are fully...