Alexey Zarakovskiy

Results 11 comments of Alexey Zarakovskiy

> Please add tests also in https://github.com/zalando/skipper/tree/master/dataclients/kubernetes/testdata/ingressV1/ingress-data . You can override kube dataclient config in the `.kube` file and if you need to enhance it you need to change `kubernetestest`...

UPD: I changed the default behavior to not default all labels to Ingress labels because I myself forgot about it when I started to use it and wasted some time...

@szuecs hey :) Could you please take another look? I've processed all your comments. If you feel somebody else needs to review it as well, could you also assign them?...

> @AlexanderYastrebov The current version is very simple and apimachinery looks very bloated, so I would rather stick with this one. I actually initially started to implement all the logic...

@szuecs thanks, we had the similar option in mind too but decided to first verify if we could optimize the querying somehow. I am currently playing with a POC that...

I made a draft PR to showcase the implementation. I'm still in progress with it (have some issues with the tests :( ) but accidentally opened it in the main...

Hi @niafly do you have any plans to finish this?

Although this means that your model is nor properly registered, this should be different exception than NPE. So basically we should add here some explicit error handling when entity class...

This is indeed a point to improve. Your solutions works but this is not an ideal option without any doubts. Although, since we can't really predict whether we currently have...