Ayushman Chhabra

Results 118 comments of Ayushman Chhabra

@NiasuK You can apply the patches in this PR and test it out - will probably have to update bunch of deps again. I used to maintain a fork but...

@fengmk2 @atian25 I am interested in getting this merged. The module is used in [nw-builder](https://github.com/nwutils/nw-builder). Currently, it is not recognising symbolic links on decompression. This would help a ton!

```shell ninja -C outst/nw dump ninja: Entering directory `outst/nw' [1/20] ACTION //chrome/test/chromedriver/constants:version_header_action(//build/toolchain/win:win_clang_x64) [2/20] STAMP obj/chrome/test/chromedriver/constants/version_header_action.stamp [3/20] ACTION //chrome/test/chromedriver:embed_mobile_devices_in_cpp(//build/toolchain/win:win_clang_x64) [4/20] STAMP obj/chrome/test/chromedriver/embed_mobile_devices_in_cpp.stamp [5/20] CXX obj/chrome/test/chromedriver/constants/version_header/version.obj [6/20] STAMP obj/chrome/test/chromedriver/automation_client_lib.inputdeps.stamp [7/20] STAMP obj/chrome/test/chromedriver/lib.inputdeps.stamp...

Hope the issue was resolved. Please use the mailing list for discussions, thanks!

Honestly I prefer GitHub issues too but that's what Roger wants (its even mentioned in the issue template)

https://github.com/nwjs/chromium.src/blob/773647cae90a74f3c085b387912216fa6283847d/chrome/app/chrome_main_delegate.cc#L1412 Here is the code which (tries to) update the Helper apps. I suggest removing this and letting nw-builder handle renaming the Helper apps.

Okay, thanks for the quick response. Afk right now, but will give this a shot soon!

For Linux arm builds, we would need to create a custom manifest file and use https://github.com/LeonardLaszlo/nw.js-armv7-binaries/releases/ as the downloadUrl