compressing icon indicating copy to clipboard operation
compressing copied to clipboard

feat: support uncompressing symlink

Open atian25 opened this issue 6 years ago • 5 comments

atian25 avatar Jul 26 '19 14:07 atian25

@atian25 ci 没过。

fengmk2 avatar Jul 26 '19 14:07 fengmk2

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@7d605fe). Click here to learn what that means. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #31   +/-   ##
=========================================
  Coverage          ?   39.77%           
=========================================
  Files             ?       19           
  Lines             ?      533           
  Branches          ?        0           
=========================================
  Hits              ?      212           
  Misses            ?      321           
  Partials          ?        0
Impacted Files Coverage Δ
lib/utils.js 58.4% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7d605fe...e9b5b7b. Read the comment docs.

codecov[bot] avatar Jul 26 '19 16:07 codecov[bot]

Codecov Report

Merging #31 (72dbca9) into master (d17b1ed) will increase coverage by 11.91%. The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           master      #31       +/-   ##
===========================================
+ Coverage   85.82%   97.74%   +11.91%     
===========================================
  Files          19       19               
  Lines        1009     1018        +9     
  Branches      221      271       +50     
===========================================
+ Hits          866      995      +129     
+ Misses        143       23      -120     
Files Changed Coverage Δ
lib/utils.js 98.10% <100.00%> (+31.27%) :arrow_up:

... and 4 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Jul 26 '19 16:07 codecov[bot]

@atian25 ci 修一下?

fengmk2 avatar Aug 28 '19 10:08 fengmk2

ci 文件权限那个有点奇怪,本地没问题,ci 的权限不一样

atian25 avatar Aug 28 '19 11:08 atian25

我晚点 rebase 一下继续推进。

fengmk2 avatar May 11 '23 05:05 fengmk2

@fengmk2 @atian25 I am interested in getting this merged. The module is used in nw-builder. Currently, it is not recognising symbolic links on decompression. This would help a ton!

ayushmanchhabra avatar Aug 23 '23 19:08 ayushmanchhabra

@ayushmanchhabra Sure, I will merge it in this week.

fengmk2 avatar Aug 24 '23 01:08 fengmk2

While this looks like it should work, its still not processing symlinks properly on extract

zkrige avatar Sep 04 '23 11:09 zkrige