Andrew Pikul

Results 62 comments of Andrew Pikul

Not packing `dagre` in w/ `cytoscape-dagre.js` seems a bit offbeat to me if using webpack.

@aloisklink I think they just merged my changes to the main library! So the main library should be native esm now. I'll be reviewing all this this weekend to see...

Yeah so, honestly, it seems kinda weird over there. I think my conversions might be a hard pill to swallow, rollup provides a better experience. But still, they reverted a...

Hey @archmoj I'd be willing to wrap up a could of PRs from third parties that interest you if a) my work is acceptable to you and b) we could...

Re: https://github.com/plotly/plotly.js/pull/6827/commits/6d48a3b87df9111ab7c7b7a98e1d726a799adb49 "Fix bug by which..." and "redrawing issue": - [x] Find where ticks are redrawn on zoom (like in "auto") and make redraw proportional (will probably fix below) -...

Alright that's pretty good. One more commit for whatever lint the bot picks up. I'll write tests after I get a response from devs. Questions for devs: - Multicategories, should...

This strategy currently doesn't work if both major and minor ticks are `proportional` because plotly's array-mode conditions in `calcTicks` are broken. As of now, `calcTicks` cannot actually separate major and...

Alright, the testing is parameterized and randomized: It tests `xaxis.tickmode:'proportional'` `xaxis.minor.tickmode:'proportional'` `yaxis.tickmode:'proportional'` and `yaxis.minor.tickmode:'proportional'` in every permutation. Understandably, it's failling as a result of https://github.com/plotly/plotly.js/issues/6828. All `tickval` are randomized, both...

Two suggestions by Alex coming tonight: 1) Change Name 2) Additional mode to allow generation of ticks along domain w/o Tomrrow: 3) Test for #2 tomorrow

@archmoj alex is suggesting a different strategy for implementing this so i was thinking of letting this branch die? edit: merged and done either way