Enhance `hole` property in Pie Chart for variable slice radii

[barrymichaeldoyle]

Refined the Pie Chart to permit the hole property to accept both numbers and arrays. This enhancement facilitates setting individual radii for each pie slice, offering greater customization in visual representation.

Addresses: https://github.com/plotly/plotly.js/issues/6768

[barrymichaeldoyle]

I'm not sure why the webgl-jasmine tests are failing, it seems unrelated to this PR.

[archmoj]

I'm not sure why the webgl-jasmine tests are failing, it seems unrelated to this PR.

Yes it is unrelated to this PR and it would be fixed on master shortly.

[archmoj]

Thanks for the PR. Please see my comment here on how to add and handle an arrayOk attribute.

[barrymichaeldoyle]

@archmoj thank you, please see my updated PR for review 👌

[barrymichaeldoyle]

I think I might need some help with this.

[archmoj]

I'm not sure why the webgl-jasmine tests are failing, it seems unrelated to this PR.

Please fetch upstream/master and merge it to this branch which would fix the webgl-jasmine test. Thanks!

[archmoj]

I think I might need some help with this.

After running npm start, if you run npm run schema it would update test/plot-schema.json file. Then you can commit it. That would fix publish-dist test.

[barrymichaeldoyle]

I think I might need some help with this.

After running npm start, if you run npm run schema it would update test/plot-schema.json file. Then you can commit it. That would fix publish-dist test.

Awesome, I've done that, synced up to master and resolved the review item 👍

[archmoj]

Looking good to me. Could you please add a mock named zz-pie-hole-array.json at test/image/mocks/ with some pies to test this feature? Thank you!

[archmoj]

We are in the process of releasing a minor version soon. I'd like to include this feature but the test is still missing.

[ayjayt]

Hey @archmoj I'd be willing to wrap up a could of PRs from third parties that interest you if a) my work is acceptable to you and b) we could talk about fast-tracking some feature additions I want to do (I have a comercial need). Thanks!

[barrymichaeldoyle]

I'm sorry I've been so inactive on wrapping up this issue. I've been taking a break. I'll be back next week to tackle this. I understand if the next minor version doesn't include this feature due to my inactivity.

[archmoj]

I'm sorry I've been so inactive on wrapping up this issue. I've been taking a break. I'll be back next week to tackle this. I understand if the next minor version doesn't include this feature due to my inactivity.

No problem. We are still in the process of working on new features for the next minor. So we could include it when it is ready.

[archmoj]

@barrymichaeldoyle Are you interested to completing this PR?

[barrymichaeldoyle]

Hey there,

Yeah sorry we’ve move on to a different library for our chart so I don’t use plotly anymore 😕

If anyone else is interest in wrapping this one up, go for it!

On Sat, 13 Jul 2024 at 20:48, Mojtaba Samimi @.***> wrote:

@barrymichaeldoyle https://github.com/barrymichaeldoyle Are you interested to completing this PR?

— Reply to this email directly, view it on GitHub https://github.com/plotly/plotly.js/pull/6769#issuecomment-2227044681, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABDVHNT23JHASUQEGVJADP3ZMFY7JAVCNFSM6AAAAABK2PRU3GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRXGA2DINRYGE . You are receiving this because you were mentioned.Message ID: @.***>

[archmoj]

I don't see a use case for this feature at this moment. Closing.