Andrew Wilkins

Results 473 comments of Andrew Wilkins

I'm generally in favour of assuming everything is retryable and special-casing permanent errors - that proposed config LGTM. Related: https://github.com/open-telemetry/opentelemetry-collector/issues/14174

@sfc-gh-sili could you please clarify the scope of of partitioning that we'll support in exporterhelper? > A partition represents the logical separation of the data based on the input (e.g....

> IIUC, this requires 1. moving ottl from opentelemetry-collector-contrib into openelemetry-collector and 2. extending ottl so it can access metadata. The latter sounds more straightforward, but I am not sure...

We discussed this in Collector SIG just now: @dmitryax mentioned that OTTL may come to core one day, but it's not ready and is not likely to be ready before...

I spent some more time looking into this. Intra-batch partitioning may be relevant earlier in a pipeline, e.g. see [groupbyattrsprocessor](https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/processor/groupbyattrsprocessor) and [groupbytraceprocessor](https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/processor/groupbytraceprocessor). A general purpose OTTL-based grouping processor could replace...

Copying my comments from https://github.com/open-telemetry/opentelemetry-collector/pull/14139#discussion_r2613616738: Looking into this again, and now I can't see how the extension approach can even be guaranteed to work. Previously I thought it could, but...

We'll need to either update gopls to v0.21.0-pre.2, or wait until v0.21.0 is released.

> We'll need to either update gopls to v0.21.0-pre.2, or wait until v0.21.0 is released. Tracking issue: https://github.com/golang/go/issues/76367

Next problem: [email protected] needs Go 1.25. So we'll need to wait until February.

@dehaansa I've gone ahead and added you as sponsor & code owner in the description. Please report back when you're happy to proceed.