Andrew Wilkins
Andrew Wilkins
> This will ensure that a group will exit either whenever it's closed or whenever the cluster closes, and avoids all timing races. Wdyt? That looks like a better approach...
I've taken your diff above exactly as-is: https://github.com/twmb/franz-go/pull/1046
Sounds reasonable to me, let's see what the code owners think. My initial thought was you could run multiple receivers, but IIANM that would lead to multiple connection pools which...
Thanks for confirming! > By the way, have you seen the related issue open-telemetry/opentelemetry-collector#13113? It complements this one. I've seen it. If I'm not mistaken, for that issue to be...
@kaisecheng have you considered this alternative? Parse the "target", and transform it to a statement like `set(, )`, where `` is a value expression that will resolve to the (presumably...
> Processor has limit flexibility to config the target and expects a follow-up transform processor to set the value to desired position > ... > > (1) is the alternative...
Should we have this for configgrpc too? And non-HTTP/gRPC? I'm wondering if we should make a breaking change to confighttp.ServerConfig to use confignet.AddrConfig, similar to configgrpc: https://github.com/open-telemetry/opentelemetry-collector/blob/c657d5d4e920c20052a12820abeef928e743c609/config/configgrpc/configgrpc.go#L176 Then we could...
@sinkingpoint :+1: that seems fine, we can always make a breaking change independently if desired.
> Actually, looking at it a bit more: configgrpc provides .Serve(net.Listener), and all the uses in the contrib repo actually use confighttps ToListener to create the listener to pass into...
Ah I see. That receiver probably should be updated, but I digress A separate PR sounds good to me, maybe change the description so the issue doesn't get closed when...