Andrew Wilkins
Andrew Wilkins
Adding support for non-AWS MSK SASL/OAUTHBEARER sounds reasonable to me. > These properties include, but are not limited to: > > sasl.mechanism=OAUTHBEARER > sasl.login.callback.handler.class= > sasl.jaas.config= This is JAAS config,...
/label -needs-triage
As above I think this makes sense, but to be very explicit: I don't personally have a need for this, so it's not high on my priority list to implement....
@Schm1tz1 great! :) Here are a few pointers. 1. You would need to add configuration settings to internal/kafka/configkafka.SASLConfig: https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/16ac39d8db602bd6207685c90c61739354038e48/internal/kafka/configkafka/config.go#L299-L300 2. Update internal/kafka.configureSASL to set the relevant parts of the Sarama...
@anderius the auth configuration is shared between receiver and exporter, so it would automatically apply to both.
@evan-bradley @TylerHelmuth can you please take a look?
> Don't we need to update documentation on how to use this? @dmitryax this is an API-only change for now, not visible to users. Or are you saying there's some...
> For the configgrpc package, we see: > - client metadata is copied after auth succeeds by construction > For the confighttp package ... We see: > - client metadata...
> Should client metadata be copied after auth succeeds? Client metadata is relevant for auth, so I'd be inclined to keep it this way. Also bear in mind that authenticators...