Axetroy
Axetroy
So, how should I distinguish which properties/objects are more reasonable to access on window? This should be the DOM/BOM API. Do I need to maintain this list in plugin, or...
I added several common APIs, basically DOM and BOM interfaces, welcome to add the missing parts
> Please try to reuse existing utilities. @fisker Can you review it again?
CI failed, But it doesn't seem to be caused by this PR Same with https://github.com/sindresorhus/eslint-plugin-unicorn/actions/runs/10377594904/job/28732103760 ``` no-for-loop › invalid(1): for (let i = 0; i < positions.length; i++) { \u0009let...
> will there be any new progress? 😳 This PR is almost ready to be merged. Block by #2424
> Not sure about the strategy for unknown properties here. > > ``` > window[foo]; > const foo = 'name'; window[foo]; > const foo = 'not-name'; window[foo]; > ``` >...
> Let us know when this is ready for another review. Make sure [#2410 (files)](https://github.com/sindresorhus/eslint-plugin-unicorn/pull/2410/files#r1710020285) is resolved first. > I think we should ignore them, or simply ignore all computed...
@fisker Could you please review it again and let me know if there is anything that needs to change
> I did not reviewed this PR carefully. Inspired by the implementation of eslint built-in rule [no-restricted-globals](https://github.com/eslint/eslint/blob/main/lib/rules/no-restricted-globals.js?rgh-link-date=2024-09-10T07%3A14%3A02Z). I provide a simple demo to implement it. > > ```js > {...
> I did not reviewed this PR carefully. Inspired by the implementation of eslint built-in rule [no-restricted-globals](https://github.com/eslint/eslint/blob/main/lib/rules/no-restricted-globals.js?rgh-link-date=2024-09-10T07%3A14%3A02Z). I provide a simple demo to implement it. > > ```js > {...